Page MenuHomePhabricator

Fix task hovercards showing a "Not Editable" state
ClosedPublic

Authored by epriestley on Mar 26 2019, 10:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 9:55 AM
Unknown Object (File)
Mon, Apr 1, 10:49 PM
Unknown Object (File)
Mon, Apr 1, 10:49 PM
Unknown Object (File)
Mon, Apr 1, 7:54 PM
Unknown Object (File)
Mon, Apr 1, 5:25 PM
Unknown Object (File)
Mon, Apr 1, 8:49 AM
Unknown Object (File)
Sun, Mar 31, 6:38 PM
Unknown Object (File)
Sun, Mar 31, 1:25 PM
Subscribers
None

Details

Summary

Ref T13269. These cards really have three states:

  • Editable: shows a pencil icon edit button.
  • You Do Not Have Permission To Edit This: shows a "no editing" icon in red.
  • Hovecard: shouldn't show anything.

However, the "hovercard" and "no permission" states are currently the same state, so when I made the "no permission" state more obvious that made the hovercard go all weird.

Make these states explicitly separate states.

Test Plan

Looked at a...

  • Editable card on workboard: edit state.
  • No permission card on workboard: no permission state.
  • Any hovercard: "not editable, this is a hovercard" state.

Diff Detail

Repository
rP Phabricator
Branch
card1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22395
Build 30639: Run Core Tests
Build 30638: arc lint + arc unit