Page MenuHomePhabricator

Fix task hovercards showing a "Not Editable" state
ClosedPublic

Authored by epriestley on Mar 26 2019, 10:47 PM.
Tags
None
Referenced Files
F22676293: D20330.id48524.diff
Thu, Oct 1, 10:25 PM
F22676291: D20330.id48525.diff
Thu, Oct 1, 10:25 PM
F22675704: D20330.diff
Thu, Oct 1, 9:56 PM
F22543892: D20330.id48524.diff
Tue, Sep 22, 6:50 PM
Unknown Object (File)
Aug 30 2026, 7:06 PM
Unknown Object (File)
Aug 30 2026, 7:06 PM
Unknown Object (File)
Aug 30 2026, 7:06 PM
Unknown Object (File)
Aug 28 2026, 1:54 PM
Subscribers
None

Details

Summary

Ref T13269. These cards really have three states:

  • Editable: shows a pencil icon edit button.
  • You Do Not Have Permission To Edit This: shows a "no editing" icon in red.
  • Hovecard: shouldn't show anything.

However, the "hovercard" and "no permission" states are currently the same state, so when I made the "no permission" state more obvious that made the hovercard go all weird.

Make these states explicitly separate states.

Test Plan

Looked at a...

  • Editable card on workboard: edit state.
  • No permission card on workboard: no permission state.
  • Any hovercard: "not editable, this is a hovercard" state.

Diff Detail

Repository
rP Phabricator
Branch
card1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22395
Build 30639: Run Core Tests
Build 30638: arc lint + arc unit