Page MenuHomePhabricator

Raise a more tailored exception if transform/thumbnail support is missing for cover images
ClosedPublic

Authored by epriestley on Mar 26 2019, 9:24 PM.
Tags
None
Referenced Files
F13348688: D20328.diff
Sat, Jun 22, 11:07 PM
F13341897: D20328.diff
Thu, Jun 20, 9:09 AM
F13340632: D20328.diff
Thu, Jun 20, 3:15 AM
F13337222: D20328.diff
Wed, Jun 19, 9:19 AM
F13324663: D20328.diff
Sat, Jun 15, 12:52 AM
F13272778: D20328.diff
Thu, May 30, 8:52 PM
F13263173: D20328.id48521.diff
Mon, May 27, 7:33 AM
F13252853: D20328.diff
May 25 2024, 2:08 AM
Subscribers
None

Details

Summary

If "GD" doesn't support a particular image type, applying a cover image currently goes through but no-ops. Fail it earlier in the process with a more specific error.

Test Plan

Without PNG support locally, dropped a PNG onto a card on a workboard. Got a more useful error.

Diff Detail

Repository
rP Phabricator
Branch
cover1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22392
Build 30634: Run Core Tests
Build 30633: arc lint + arc unit