Page MenuHomePhabricator
Differential D20328

Raise a more tailored exception if transform/thumbnail support is missing for cover images
ClosedPublic
Actions

Authored by epriestley on Mar 26 2019, 9:24 PM.
Tags
None
Referenced Files
F15504271: D20328.id48521.diff
Mon, Apr 14, 5:04 PM
F15500646: D20328.id48521.diff
Sun, Apr 13, 6:47 PM
F15492665: D20328.diff
Sat, Apr 12, 5:00 PM
F15490578: D20328.id48522.diff
Fri, Apr 11, 6:34 PM
F15487098: D20328.id.diff
Thu, Apr 10, 11:14 AM
F15486531: D20328.id48522.diff
Thu, Apr 10, 8:02 AM
F15482756: D20328.diff
Wed, Apr 9, 7:47 AM
F15427079: D20328.id48521.diff
Sun, Mar 23, 12:38 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rPb328af0a1b16: Raise a more tailored exception if transform/thumbnail support is missing for…
Summary

If "GD" doesn't support a particular image type, applying a cover image currently goes through but no-ops. Fail it earlier in the process with a more specific error.

Test Plan

Without PNG support locally, dropped a PNG onto a card on a workboard. Got a more useful error.

Diff Detail

Repository
rP Phabricator
Branch
cover1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22392
Build 30634: Run Core Tests
Build 30633: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
xaction/
36 lines

Diff 48521

View Options

src/applications/maniphest/xaction/ManiphestTaskCoverImageTransaction.php

Loading...
Phabricator · Built by Phacility