Page MenuHomePhabricator

Raise a more tailored exception if transform/thumbnail support is missing for cover images
ClosedPublic

Authored by epriestley on Mar 26 2019, 9:24 PM.
Tags
None
Referenced Files
F19503798: D20328.diff
Fri, Jan 9, 1:44 AM
F18877640: D20328.id.diff
Nov 6 2025, 11:08 AM
F18873126: D20328.diff
Nov 5 2025, 8:07 AM
F18780413: D20328.id48521.diff
Oct 12 2025, 12:16 PM
F18751488: D20328.id.diff
Oct 4 2025, 11:21 AM
F18745554: D20328.diff
Oct 3 2025, 7:53 AM
F18606258: D20328.diff
Sep 13 2025, 9:57 PM
F18518456: D20328.diff
Sep 5 2025, 3:16 PM
Subscribers
None

Details

Summary

If "GD" doesn't support a particular image type, applying a cover image currently goes through but no-ops. Fail it earlier in the process with a more specific error.

Test Plan

Without PNG support locally, dropped a PNG onto a card on a workboard. Got a more useful error.

Diff Detail

Repository
rP Phabricator
Branch
cover1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22392
Build 30634: Run Core Tests
Build 30633: arc lint + arc unit