Differential D20328

Raise a more tailored exception if transform/thumbnail support is missing for cover images
ClosedPublic
Actions

Authored by epriestley on Mar 26 2019, 9:24 PM.

Details

Reviewers

Commits

rPb328af0a1b16: Raise a more tailored exception if transform/thumbnail support is missing for…

Summary

If "GD" doesn't support a particular image type, applying a cover image currently goes through but no-ops. Fail it earlier in the process with a more specific error.

Test Plan

Without PNG support locally, dropped a PNG onto a card on a workboard. Got a more useful error.

Diff Detail

Repository

rP Phabricator

Branch

cover1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22392
Build 30634: Run Core Tests
Build 30633: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 26 2019, 9:24 PM

Harbormaster completed remote builds in B22392: Diff 48521.Mar 26 2019, 9:26 PM

epriestley requested review of this revision.Mar 26 2019, 9:26 PM

amckinley accepted this revision.Mar 26 2019, 9:42 PM

This revision is now accepted and ready to land.Mar 26 2019, 9:42 PM

Closed by commit rPb328af0a1b16: Raise a more tailored exception if transform/thumbnail support is missing for… (authored by epriestley). · Explain WhyMar 26 2019, 10:16 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

xaction/

ManiphestTaskCoverImageTransaction.php

36 lines

Diff 48521

View Options

src/applications/maniphest/xaction/ManiphestTaskCoverImageTransaction.php

Raise a more tailored exception if transform/thumbnail support is missing for cover imagesClosedPublicActions