Page MenuHomePhabricator
Differential D20328

Raise a more tailored exception if transform/thumbnail support is missing for cover images
ClosedPublic
Actions

Authored by epriestley on Mar 26 2019, 9:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 7:27 AM
Unknown Object (File)
Mon, Apr 1, 10:49 PM
Unknown Object (File)
Thu, Mar 28, 7:45 PM
Unknown Object (File)
Feb 6 2024, 1:31 AM
Unknown Object (File)
Dec 26 2023, 1:59 AM
Unknown Object (File)
Dec 22 2023, 8:04 PM
Unknown Object (File)
Nov 30 2023, 5:31 AM
Unknown Object (File)
Nov 18 2023, 4:57 PM
View All 61 Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rPb328af0a1b16: Raise a more tailored exception if transform/thumbnail support is missing for…
Summary

If "GD" doesn't support a particular image type, applying a cover image currently goes through but no-ops. Fail it earlier in the process with a more specific error.

Test Plan

Without PNG support locally, dropped a PNG onto a card on a workboard. Got a more useful error.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
xaction/
36 lines

Diff 48522

View Options

src/applications/maniphest/xaction/ManiphestTaskCoverImageTransaction.php

Loading...
Phabricator · Built by Phacility