Fix an unusual internal cursor in Conpherence
ClosedPublic
Actions

Authored by epriestley on Mar 24 2019, 8:58 PM.

Details

Reviewers

Commits

rP9f1104229332: (stable) Fix an unusual internal cursor in Conpherence
rP2ebe675ae5ec: Fix an unusual internal cursor in Conpherence

Summary

See https://discourse.phabricator-community.org/t/error-when-sending-a-message-chat-room/2548.

Conpherence calls setAfterID() and setBeforeID() directly on a subquery, but these methods no longer exist.

Use a pager instead. This code probably shouldn't exist (we should use some other approach to fetch this data in most cases) but that's a larger change.

Test Plan

Sent messages in a Conpherence thread. Before: fatal; after: success. Viewed the Conphrence menu, loaded threads, etc.

Diff Detail

Repository

rP Phabricator

Branch

thread1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22343
Build 30571: Run Core Tests
Build 30570: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 24 2019, 8:58 PM

Harbormaster completed remote builds in B22343: Diff 48473.Mar 24 2019, 9:00 PM

epriestley requested review of this revision.Mar 24 2019, 9:00 PM

amckinley accepted this revision.Mar 25 2019, 5:39 PM

amckinley added inline comments.

src/applications/conpherence/query/ConpherenceThreadQuery.php
297	Que?

This revision is now accepted and ready to land.Mar 25 2019, 5:39 PM

epriestley added inline comments.Mar 25 2019, 5:46 PM

src/applications/conpherence/query/ConpherenceThreadQuery.php
297	We must specify a page size to the Pager (it defaults to 100 otherwise) and Pagers don't understand "null/no limit". No caller should be loading every transaction but I didn't actually trace everything down (since I'm pretty sure this code just needs to be removed in the future?) so 0xFFFF is just "a big number that probably won't break anything".

Closed by commit rP2ebe675ae5ec: Fix an unusual internal cursor in Conpherence (authored by epriestley). · Explain WhyMar 25 2019, 5:53 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

query/

ConpherenceThreadQuery.php

34 lines

Diff 48473

View Options

src/applications/conpherence/query/ConpherenceThreadQuery.php

Fix an unusual internal cursor in ConpherenceClosedPublicActions