Page MenuHomePhabricator

Track how many columns use a particular trigger
ClosedPublic

Authored by epriestley on Mar 22 2019, 3:09 PM.
Tags
None
Referenced Files
F13971579: D20308.id48505.diff
Thu, Oct 17, 2:04 PM
F13958862: D20308.id.diff
Mon, Oct 14, 4:46 PM
Unknown Object (File)
Thu, Oct 10, 5:11 AM
Unknown Object (File)
Wed, Oct 2, 6:11 AM
Unknown Object (File)
Sun, Sep 29, 10:28 PM
Unknown Object (File)
Thu, Sep 26, 3:49 AM
Unknown Object (File)
Sun, Sep 22, 9:55 PM
Unknown Object (File)
Sun, Sep 22, 4:38 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T5474. In 99% of cases, a separate "archived/active" status for triggers probably doesn't make much sense: there's not much reason to ever disable/archive a trigger explcitly, and the archival rule is really just "is this trigger used by anything?".

(The one reason I can think of to disable a trigger manually is because you want to put something in a column and skip trigger rules, but you can already do this from the task detail page anyway, and disabling the trigger globally is a bad way to accomplish this if it's in use by other columns.)

Instead of adding a separate "status", just track how many columns a trigger is used by and consider it "inactive" if it is not used by any active columns.

Test Plan

This is slightly hard to test exhaustively since you can't share a trigger across multiple columns right now, but: rebuild indexes, poked around the trigger list and trigger details, added/removed triggers.

Diff Detail

Repository
rP Phabricator
Branch
trigger13
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22326
Build 30544: Run Core Tests
Build 30543: arc lint + arc unit