Page MenuHomePhabricator

Modularize HeraldRule transactions
ClosedPublic

Authored by epriestley on Mar 7 2019, 1:02 PM.
Tags
None
Referenced Files
F13268696: D20258.diff
Wed, May 29, 5:18 AM
F13254273: D20258.diff
Sat, May 25, 3:17 AM
F13233586: D20258.diff
Tue, May 21, 2:25 AM
F13214563: D20258.id48361.diff
Fri, May 17, 11:25 AM
F13211726: D20258.diff
Fri, May 17, 6:02 AM
F13209605: D20258.id48361.diff
Fri, May 17, 1:05 AM
F13195407: D20258.diff
Sun, May 12, 10:22 PM
F13179511: D20258.diff
Wed, May 8, 9:15 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13249. See PHI1115. I initially wanted to make bin/policy unlock --owner <user> H123 work to transfer ownership of a Herald rule, although I'm no longer really sure this makes much sense.

In any case, this makes things a little better and more modern.

I removed the storage table for rule comments. Adding comments to Herald rules doesn't work and probably doesn't make much sense.

Test Plan

Created and edited Herald rules, grepped for all the transaction type constants.

Diff Detail

Repository
rP Phabricator
Branch
unlock3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22220
Build 30382: Run Core Tests
Build 30381: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.Mar 7 2019, 1:02 PM
amckinley added inline comments.
src/applications/herald/xaction/HeraldRuleNameTransaction.php
35

Unused variable.

This revision is now accepted and ready to land.Mar 7 2019, 6:40 PM
epriestley retitled this revision from Modularize Herald transactions to Modularize HeraldRule transactions.Mar 7 2019, 6:40 PM
This revision was automatically updated to reflect the committed changes.