Page MenuHomePhabricator

Modularize HeraldRule transactions
ClosedPublic

Authored by epriestley on Mar 7 2019, 1:02 PM.
Tags
None
Referenced Files
F14086211: D20258.diff
Sat, Nov 23, 2:19 PM
Unknown Object (File)
Tue, Nov 19, 8:32 AM
Unknown Object (File)
Fri, Nov 15, 6:31 AM
Unknown Object (File)
Mon, Nov 11, 2:37 AM
Unknown Object (File)
Sun, Nov 10, 8:07 PM
Unknown Object (File)
Thu, Nov 7, 2:29 PM
Unknown Object (File)
Oct 23 2024, 12:40 PM
Unknown Object (File)
Oct 17 2024, 9:30 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13249. See PHI1115. I initially wanted to make bin/policy unlock --owner <user> H123 work to transfer ownership of a Herald rule, although I'm no longer really sure this makes much sense.

In any case, this makes things a little better and more modern.

I removed the storage table for rule comments. Adding comments to Herald rules doesn't work and probably doesn't make much sense.

Test Plan

Created and edited Herald rules, grepped for all the transaction type constants.

Diff Detail

Repository
rP Phabricator
Branch
unlock3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22209
Build 30363: Run Core Tests
Build 30362: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.Mar 7 2019, 1:02 PM
amckinley added inline comments.
src/applications/herald/xaction/HeraldRuleNameTransaction.php
34

Unused variable.

This revision is now accepted and ready to land.Mar 7 2019, 6:40 PM
epriestley retitled this revision from Modularize Herald transactions to Modularize HeraldRule transactions.Mar 7 2019, 6:40 PM
This revision was automatically updated to reflect the committed changes.