Page MenuHomePhabricator

Add an "Restartable: If Failed" behavior to Harbormaster build plans
ClosedPublic

Authored by epriestley on Mar 6 2019, 5:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 24, 3:16 AM
Unknown Object (File)
Fri, Dec 13, 12:41 AM
Unknown Object (File)
Thu, Dec 12, 10:39 PM
Unknown Object (File)
Thu, Dec 12, 10:39 PM
Unknown Object (File)
Thu, Dec 12, 10:39 PM
Unknown Object (File)
Thu, Nov 28, 9:05 AM
Unknown Object (File)
Tue, Nov 26, 10:19 PM
Unknown Object (File)
Tue, Nov 26, 3:42 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13249. Ref T13258. In some cases, builds are not idempotent and should not be restarted casually.

If the scary part is at the very end (deploy / provision / whatever), it could be okay to restart them if they previously failed.

Also, make the "reasons why you can't restart" and "explanations of why you can't restart" logic a little more cohesive.

Test Plan
  • Tried to restart builds in various states (failed/not failed, restartable always/if failed/never, already restarted), got appropriate errors or restarts.
  • (I'm not sure the "Autoplan" error is normally reachable, since you can't edit autoplans to configure things to let you try to restart them.)

Diff Detail

Repository
rP Phabricator
Branch
restart1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22203
Build 30351: Run Core Tests
Build 30350: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.Mar 6 2019, 5:39 PM
This revision is now accepted and ready to land.Mar 7 2019, 10:10 PM
This revision was automatically updated to reflect the committed changes.