Paths

Table of Contentst

Differential D20236

Implement "Warn When Landing" behavior for Build Plans in Arcanist
ClosedPublic
Actions

Authored by epriestley on Mar 1 2019, 2:13 PM.

Tags

None

Referenced Files

	F15513114: D20236.id48303.diff
	Thu, Apr 17, 4:29 PM

	F15505220: D20236.diff
	Tue, Apr 15, 12:53 AM

	F15490092: D20236.id48303.diff
	Fri, Apr 11, 2:14 PM

	F15488039: D20236.id48341.diff
	Thu, Apr 10, 6:53 PM

	F15486827: D20236.id.diff
	Thu, Apr 10, 9:48 AM

	F15482686: D20236.id48342.diff
	Wed, Apr 9, 7:14 AM

	F15476960: D20236.id.diff
	Mon, Apr 7, 10:37 AM

	F15474572: D20236.diff
	Sun, Apr 6, 9:53 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc)

Commits

rARCf6b8480adce5: Implement "Warn When Landing" behavior for Build Plans in Arcanist

Summary

Ref T13258. This makes "arc land" respect the new "Warn When Landing" behavior.

This will only work if you have very up-to-date APIs. Just fall back to the older code if the new API calls fail.

Test Plan

Ran arc land on a revision with builds in various states and with the different "Warn When Landing" behaviors. Saw appropriate warnings.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 1 2019, 2:13 PM

Harbormaster completed remote builds in B22164: Diff 48303.Mar 1 2019, 2:14 PM

epriestley requested review of this revision.Mar 1 2019, 2:14 PM

amckinley accepted this revision.Mar 5 2019, 8:04 PM

amckinley added inline comments.

src/workflow/ArcanistLandWorkflow.php
1588	"despite ongoing build"
1611	Could the conduit URI ever be something != the web UI URI?

This revision is now accepted and ready to land.Mar 5 2019, 8:04 PM

epriestley added inline comments.Mar 6 2019, 2:35 PM

src/workflow/ArcanistLandWorkflow.php
1611	Today, they're always the same. With SSH conduit URIs in the future, they could differ. We just don't currently have a better source for this. (The API should probably return a "uri".)

Typos/spelling.

Harbormaster completed remote builds in B22200: Diff 48341.Mar 6 2019, 2:36 PM

Closed by commit rARCf6b8480adce5: Implement "Warn When Landing" behavior for Build Plans in Arcanist (authored by epriestley). · Explain WhyMar 6 2019, 2:48 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

ref/

ArcanistBuildPlanRef.php

25 lines

ArcanistBuildRef.php

27 lines

workflow/

ArcanistLandWorkflow.php

173 lines

Diff 48342

src/__phutil_library_map__.php

Loading...

src/ref/ArcanistBuildPlanRef.php

Loading...

src/ref/ArcanistBuildRef.php

Loading...

src/workflow/ArcanistLandWorkflow.php

Loading...