Page MenuHomePhabricator

Implement "Warn When Landing" behavior for Build Plans in Arcanist
ClosedPublic

Authored by epriestley on Mar 1 2019, 2:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 16, 5:22 AM
Unknown Object (File)
Feb 9 2024, 7:51 AM
Unknown Object (File)
Jan 25 2024, 3:22 AM
Unknown Object (File)
Jan 10 2024, 3:23 AM
Unknown Object (File)
Jan 8 2024, 5:55 AM
Unknown Object (File)
Dec 19 2023, 9:37 PM
Unknown Object (File)
Dec 15 2023, 2:44 PM
Unknown Object (File)
Dec 14 2023, 10:32 AM
Subscribers
None

Details

Summary

Ref T13258. This makes "arc land" respect the new "Warn When Landing" behavior.

This will only work if you have very up-to-date APIs. Just fall back to the older code if the new API calls fail.

Test Plan

Ran arc land on a revision with builds in various states and with the different "Warn When Landing" behaviors. Saw appropriate warnings.

Diff Detail

Repository
rARC Arcanist
Branch
land1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/workflow/ArcanistLandWorkflow.php:1466XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 22164
Build 30291: Run Core Tests
Build 30290: arc lint + arc unit

Event Timeline

amckinley added inline comments.
src/workflow/ArcanistLandWorkflow.php
1588

"despite ongoing build"

1611

Could the conduit URI ever be something != the web UI URI?

This revision is now accepted and ready to land.Mar 5 2019, 8:04 PM
src/workflow/ArcanistLandWorkflow.php
1611

Today, they're always the same.

With SSH conduit URIs in the future, they could differ. We just don't currently have a better source for this.

(The API should probably return a "uri".)

This revision was automatically updated to reflect the committed changes.