Page MenuHomePhabricator

Correct a possible fatal in the non-CSRF Duo MFA workflow
ClosedPublic

Authored by epriestley on Mar 1 2019, 3:28 AM.
Tags
None
Referenced Files
F13272986: D20234.diff
Fri, May 31, 1:25 AM
F13239319: D20234.id.diff
Wed, May 22, 1:53 AM
F13226911: D20234.id48294.diff
Mon, May 20, 12:06 AM
F13217479: D20234.diff
Sat, May 18, 5:40 AM
F13202916: D20234.diff
Tue, May 14, 11:18 PM
F13185102: D20234.diff
Sat, May 11, 2:36 AM
Unknown Object (File)
May 7 2024, 4:59 AM
Unknown Object (File)
May 3 2024, 2:21 AM
Subscribers
None

Details

Summary

Ref T13259. If we miss the separate CSRF step in Duo and proceed directly to prompting, we may fail to build a response which turns into a real control and fatal on null->setLabel().

Instead, let MFA providers customize their "bare prompt dialog" response, then make Duo use the same "you have an outstanding request" response for the CSRF and no-CSRF workflows.

Test Plan

Hit Duo auth on a non-CSRF workflow (e.g., edit an MFA provider with Duo enabled). Previously: setLabel() fatal. After patch: smooth sailing.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable