Page MenuHomePhabricator

Correct a possible fatal in the non-CSRF Duo MFA workflow
ClosedPublic

Authored by epriestley on Mar 1 2019, 3:28 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 2:56 PM
Unknown Object (File)
Wed, Apr 17, 1:36 PM
Unknown Object (File)
Sun, Apr 14, 9:59 PM
Unknown Object (File)
Sat, Apr 13, 6:48 AM
Unknown Object (File)
Thu, Apr 11, 7:09 AM
Unknown Object (File)
Wed, Apr 10, 4:10 PM
Unknown Object (File)
Wed, Apr 3, 12:04 PM
Unknown Object (File)
Fri, Mar 29, 6:11 AM
Subscribers
None

Details

Summary

Ref T13259. If we miss the separate CSRF step in Duo and proceed directly to prompting, we may fail to build a response which turns into a real control and fatal on null->setLabel().

Instead, let MFA providers customize their "bare prompt dialog" response, then make Duo use the same "you have an outstanding request" response for the CSRF and no-CSRF workflows.

Test Plan

Hit Duo auth on a non-CSRF workflow (e.g., edit an MFA provider with Duo enabled). Previously: setLabel() fatal. After patch: smooth sailing.

Diff Detail

Repository
rP Phabricator
Branch
duo1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22156
Build 30281: Run Core Tests
Build 30280: arc lint + arc unit