Page MenuHomePhabricator

Correct a possible fatal in the non-CSRF Duo MFA workflow
ClosedPublic

Authored by epriestley on Mar 1 2019, 3:28 AM.
Tags
None
Referenced Files
F12844855: D20234.id48324.diff
Thu, Mar 28, 11:52 PM
Unknown Object (File)
Sun, Mar 10, 12:33 AM
Unknown Object (File)
Feb 15 2024, 4:11 PM
Unknown Object (File)
Dec 24 2023, 5:23 PM
Unknown Object (File)
Dec 22 2023, 1:29 PM
Unknown Object (File)
Dec 21 2023, 4:31 AM
Unknown Object (File)
Dec 19 2023, 9:06 AM
Unknown Object (File)
Dec 14 2023, 7:39 AM
Subscribers
None

Details

Summary

Ref T13259. If we miss the separate CSRF step in Duo and proceed directly to prompting, we may fail to build a response which turns into a real control and fatal on null->setLabel().

Instead, let MFA providers customize their "bare prompt dialog" response, then make Duo use the same "you have an outstanding request" response for the CSRF and no-CSRF workflows.

Test Plan

Hit Duo auth on a non-CSRF workflow (e.g., edit an MFA provider with Duo enabled). Previously: setLabel() fatal. After patch: smooth sailing.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable