Page MenuHomePhabricator
Differential D20236

Implement "Warn When Landing" behavior for Build Plans in Arcanist
ClosedPublic
Actions

Authored by epriestley on Mar 1 2019, 2:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 12:34 PM
Unknown Object (File)
Fri, May 3, 6:41 AM
Unknown Object (File)
Thu, May 2, 10:10 PM
Unknown Object (File)
Thu, May 2, 7:41 AM
Unknown Object (File)
Sun, Apr 28, 10:59 AM
Unknown Object (File)
Fri, Apr 26, 2:45 PM
Unknown Object (File)
Thu, Apr 25, 1:15 AM
Unknown Object (File)
Tue, Apr 23, 6:59 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc)
Commits
rARCf6b8480adce5: Implement "Warn When Landing" behavior for Build Plans in Arcanist
Summary

Ref T13258. This makes "arc land" respect the new "Warn When Landing" behavior.

This will only work if you have very up-to-date APIs. Just fall back to the older code if the new API calls fail.

Test Plan

Ran arc land on a revision with builds in various states and with the different "Warn When Landing" behaviors. Saw appropriate warnings.

Diff Detail

Repository
rARC Arcanist
Branch
land1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/workflow/ArcanistLandWorkflow.php:1466XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 22164
Build 30291: Run Core Tests
Build 30290: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 1 2019, 2:13 PM
Harbormaster completed remote builds in B22164: Diff 48303.Mar 1 2019, 2:14 PM
epriestley requested review of this revision.Mar 1 2019, 2:14 PM
amckinley accepted this revision.Mar 5 2019, 8:04 PM
amckinley added inline comments.
src/workflow/ArcanistLandWorkflow.php
1588

"despite ongoing build"

1611

Could the conduit URI ever be something != the web UI URI?

This revision is now accepted and ready to land.Mar 5 2019, 8:04 PM
epriestley added inline comments.Mar 6 2019, 2:35 PM
src/workflow/ArcanistLandWorkflow.php
1611

Today, they're always the same.

With SSH conduit URIs in the future, they could differ. We just don't currently have a better source for this.

(The API should probably return a "uri".)

epriestley updated this revision to Diff 48341.Mar 6 2019, 2:35 PM
  • Typos/spelling.
Harbormaster completed remote builds in B22200: Diff 48341.Mar 6 2019, 2:36 PM
Closed by commit rARCf6b8480adce5: Implement "Warn When Landing" behavior for Build Plans in Arcanist (authored by epriestley). · Explain WhyMar 6 2019, 2:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 48303

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/ref/ArcanistBuildPlanRef.php

Loading...
View Options

src/ref/ArcanistBuildRef.php

Loading...
View Options

src/workflow/ArcanistLandWorkflow.php

Loading...
Phabricator · Built by Phacility