Page MenuHomePhabricator

Correct a possible fatal in the non-CSRF Duo MFA workflow
ClosedPublic

Authored by epriestley on Mar 1 2019, 3:28 AM.
Tags
None
Referenced Files
F19082939: D20234.id48324.diff
Tue, Dec 2, 12:27 PM
F19055732: D20234.id48324.diff
Fri, Nov 28, 6:13 PM
F18998472: D20234.diff
Nov 20 2025, 6:50 PM
F18988094: D20234.diff
Nov 18 2025, 12:19 AM
F18985060: D20234.id48294.diff
Nov 17 2025, 12:52 PM
F18944957: D20234.id48294.diff
Nov 11 2025, 5:24 PM
F18944956: D20234.id.diff
Nov 11 2025, 5:24 PM
F18901155: D20234.id48324.diff
Nov 7 2025, 9:40 PM
Subscribers
None

Details

Summary

Ref T13259. If we miss the separate CSRF step in Duo and proceed directly to prompting, we may fail to build a response which turns into a real control and fatal on null->setLabel().

Instead, let MFA providers customize their "bare prompt dialog" response, then make Duo use the same "you have an outstanding request" response for the CSRF and no-CSRF workflows.

Test Plan

Hit Duo auth on a non-CSRF workflow (e.g., edit an MFA provider with Duo enabled). Previously: setLabel() fatal. After patch: smooth sailing.

Diff Detail

Repository
rP Phabricator
Branch
duo1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22156
Build 30281: Run Core Tests
Build 30280: arc lint + arc unit