Paths

Table of Contentst

Differential D20215

"
ClosedPublic
Actions

Authored by epriestley on Feb 26 2019, 4:09 AM.

Tags

None

Referenced Files

	F18082690: D20215.id48276.diff
	Tue, Aug 5, 7:06 AM

	F17946789: D20215.id48264.diff
	Thu, Jul 31, 3:09 PM

	F17929427: D20215.id.diff
	Wed, Jul 30, 5:07 PM

	F17901295: D20215.diff
	Tue, Jul 29, 9:34 AM

	F17711995: D20215.diff
	Thu, Jul 17, 9:21 AM

	Unknown Object (File)
	Jun 26 2025, 9:13 AM

	Unknown Object (File)
	Jun 6 2025, 9:10 PM

	Unknown Object (File)
	May 30 2025, 3:54 AM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rPb28b05342bcc: Simplify one "array_keys/range" -> "phutil_is_natural_list()" in "phabricator/"

Summary

Depends on D20213. Simplify this idiom.

Test Plan

Squinted hard; grep array_keys | grep range.

Diff Detail

Repository

rP Phabricator

Branch

types2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22126
Build 30229: Run Core Tests
Build 30228: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 26 2019, 4:09 AM

Harbormaster completed remote builds in B22126: Diff 48264.Feb 26 2019, 4:11 AM

epriestley requested review of this revision.Feb 26 2019, 4:11 AM

amckinley accepted this revision.Feb 26 2019, 3:54 PM

This revision is now accepted and ready to land.Feb 26 2019, 3:54 PM

Closed by commit rPb28b05342bcc: Simplify one "array_keys/range" -> "phutil_is_natural_list()" in "phabricator/" (authored by epriestley). · Explain WhyFeb 28 2019, 3:29 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

type/

PhabricatorSetConfigType.php

2 lines

Diff 48264

View Options

src/applications/config/type/PhabricatorSetConfigType.php

Simplify one "array_keys/range" -> "phutil_is_natural_list()" in "phabricator/"ClosedPublicActions