Page MenuHomePhabricator
Differential D20204

Fix URI construction of typeahead browse "more" pager
ClosedPublic
Actions

Authored by epriestley on Feb 22 2019, 10:55 PM.
Tags
None
Referenced Files
F19515928: D20204.diff
Wed, Jan 14, 5:33 PM
F19515927: D20204.diff
Wed, Jan 14, 5:33 PM
F19515917: D20204.diff
Wed, Jan 14, 5:33 PM
F19511376: D20204.id.diff
Mon, Jan 12, 1:26 AM
F19511371: D20204.id.diff
Mon, Jan 12, 1:19 AM
F19469878: D20204.id48243.diff
Mon, Jan 5, 5:30 AM
F19469123: D20204.id48243.diff
Sun, Jan 4, 4:22 PM
F19238465: D20204.id.diff
Sun, Dec 21, 8:12 PM
View All Files
Subscribers
None
Tokens
"Mountain of Wealth" token, awarded by 20after4.

Details

Reviewers
amckinley
20after4
Maniphest Tasks
T13251: Upgrading: PhutilURI Query Parameter Changes
Commits
rPa08a03876ff2: (stable) Fix URI construction of typeahead browse "more" pager
rP90064a350a02: Fix URI construction of typeahead browse "more" pager
Summary

Ref T13251. See https://phabricator.wikimedia.org/T216849.

Test Plan
  • With more than 100 projects (or, set $limit = 3)...
  • Edit a task, then click the "Browse" magnifying glass icon next to the "Tags" typeahead.
  • Before change: fatal on 'q' being null.
  • After change: no fatal.

Diff Detail

Repository
rP Phabricator
Branch
urix1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22100
Build 30192: Run Core Tests
Build 30191: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 22 2019, 10:55 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 22 2019, 10:56 PM
Harbormaster failed remote builds in B22096: Diff 48239!
epriestley updated this revision to Diff 48243.Feb 22 2019, 11:53 PM
  • Throw away the local change which reset Git origins, so the staging area gets pushed and builds pass.
Harbormaster completed remote builds in B22100: Diff 48243.Feb 22 2019, 11:55 PM
epriestley requested review of this revision.Feb 22 2019, 11:55 PM
amckinley accepted this revision.Feb 23 2019, 2:08 AM
This revision is now accepted and ready to land.Feb 23 2019, 2:08 AM
Closed by commit rP90064a350a02: Fix URI construction of typeahead browse "more" pager (authored by epriestley). · Explain WhyFeb 23 2019, 2:09 AM
This revision was automatically updated to reflect the committed changes.
20after4 awarded a token.Feb 23 2019, 2:09 AM

Revision Contents
Changeset List

PathSize
src/
applications/
typeahead/
controller/
14 lines

Diff 48243

View Options

src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php

Loading...
Phabricator · Built by Phacility