Page MenuHomePhabricator

Fix URI construction of typeahead browse "more" pager
ClosedPublic

Authored by epriestley on Feb 22 2019, 10:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 21, 9:37 AM
Unknown Object (File)
Fri, Jan 17, 4:37 PM
Unknown Object (File)
Thu, Jan 16, 2:57 PM
Unknown Object (File)
Sun, Jan 12, 9:51 AM
Unknown Object (File)
Dec 17 2024, 10:39 AM
Unknown Object (File)
Dec 13 2024, 5:17 AM
Unknown Object (File)
Dec 7 2024, 2:48 PM
Unknown Object (File)
Dec 5 2024, 12:46 PM
Subscribers
None
Tokens
"Mountain of Wealth" token, awarded by 20after4.

Details

Summary
Test Plan
  • With more than 100 projects (or, set $limit = 3)...
  • Edit a task, then click the "Browse" magnifying glass icon next to the "Tags" typeahead.
  • Before change: fatal on 'q' being null.
  • After change: no fatal.

Diff Detail

Repository
rP Phabricator
Branch
urix1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22100
Build 30192: Run Core Tests
Build 30191: arc lint + arc unit

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 22 2019, 10:56 PM
Harbormaster failed remote builds in B22096: Diff 48239!
  • Throw away the local change which reset Git origins, so the staging area gets pushed and builds pass.
This revision is now accepted and ready to land.Feb 23 2019, 2:08 AM
This revision was automatically updated to reflect the committed changes.