Page MenuHomePhabricator

Fix URI construction of typeahead browse "more" pager
ClosedPublic

Authored by epriestley on Feb 22 2019, 10:55 PM.
Tags
None
Referenced Files
F12830794: D20204.diff
Thu, Mar 28, 12:23 PM
F12821866: D20204.id48239.diff
Thu, Mar 28, 6:57 AM
F12813830: D20204.id.diff
Thu, Mar 28, 1:30 AM
Unknown Object (File)
Sat, Mar 16, 10:56 AM
Unknown Object (File)
Tue, Mar 5, 11:05 AM
Unknown Object (File)
Fri, Mar 1, 4:48 AM
Unknown Object (File)
Feb 21 2024, 12:53 PM
Unknown Object (File)
Feb 3 2024, 9:29 PM
Subscribers
None
Tokens
"Mountain of Wealth" token, awarded by 20after4.

Details

Summary
Test Plan
  • With more than 100 projects (or, set $limit = 3)...
  • Edit a task, then click the "Browse" magnifying glass icon next to the "Tags" typeahead.
  • Before change: fatal on 'q' being null.
  • After change: no fatal.

Diff Detail

Repository
rP Phabricator
Branch
urix1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22100
Build 30192: Run Core Tests
Build 30191: arc lint + arc unit

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 22 2019, 10:56 PM
Harbormaster failed remote builds in B22096: Diff 48239!
  • Throw away the local change which reset Git origins, so the staging area gets pushed and builds pass.
This revision is now accepted and ready to land.Feb 23 2019, 2:08 AM
This revision was automatically updated to reflect the committed changes.