Page MenuHomePhabricator
Differential D20153

Clean up final `setQueryParams()` callsites
ClosedPublic
Actions

Authored by epriestley on Feb 12 2019, 9:23 PM.
Tags
None
Referenced Files
F15451054: D20153.id.diff
Fri, Mar 28, 7:53 PM
F15436369: D20153.id48119.diff
Tue, Mar 25, 1:47 PM
F15430371: D20153.id48160.diff
Mon, Mar 24, 7:22 AM
Unknown Object (File)
Feb 21 2025, 11:16 PM
Unknown Object (File)
Feb 20 2025, 10:58 PM
Unknown Object (File)
Feb 20 2025, 10:57 PM
Unknown Object (File)
Feb 14 2025, 1:30 PM
Unknown Object (File)
Feb 11 2025, 6:28 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13250: Some typeaheads use nonscalar HTTP parameters, which fatal under new "phutil_build_http_query()" rules
Commits
rP241f06c9ffc6: Clean up final `setQueryParams()` callsites
Summary

Ref T13250. See D20149.

Test Plan

All trivial?

Diff Detail

Repository
rP Phabricator
Branch
uri4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21963
Build 29995: Run Core Tests
Build 29994: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 12 2019, 9:23 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 12 2019, 9:24 PM
Harbormaster failed remote builds in B21963: Diff 48119!
epriestley requested review of this revision.Feb 12 2019, 9:24 PM

Depends on D20149.

amckinley accepted this revision.Feb 14 2019, 7:32 PM
This revision is now accepted and ready to land.Feb 14 2019, 7:32 PM
Closed by commit rP241f06c9ffc6: Clean up final `setQueryParams()` callsites (authored by epriestley). · Explain WhyFeb 14 2019, 7:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
aphront/
5 lines
response/
2 lines
applications/
auth/
provider/
2 lines
files/
controller/
2 lines

Diff 48119

View Options

src/aphront/AphrontRequest.php

Loading...
View Options

src/aphront/response/AphrontResponse.php

Loading...
View Options

src/applications/auth/provider/PhabricatorAuthProvider.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileDataController.php

Loading...
Phabricator · Built by Phacility