Page MenuHomePhabricator
Files F15451054

D20153.id.diff
No OneTemporary
Actions

D20153.id.diff
View Options

diff --git a/src/aphront/AphrontRequest.php b/src/aphront/AphrontRequest.php
--- a/src/aphront/AphrontRequest.php
+++ b/src/aphront/AphrontRequest.php
@@ -829,7 +829,10 @@
}
$uri->setPath($this->getPath());
- $uri->setQueryParams(self::flattenData($_GET));
+ $uri->removeAllQueryParams();
+ foreach (self::flattenData($_GET) as $query_key => $query_value) {
+ $uri->appendQueryParam($query_key, $query_value);
+ }
$input = PhabricatorStartup::getRawInput();
diff --git a/src/aphront/response/AphrontResponse.php b/src/aphront/response/AphrontResponse.php
--- a/src/aphront/response/AphrontResponse.php
+++ b/src/aphront/response/AphrontResponse.php
@@ -218,7 +218,7 @@
$uri = id(new PhutilURI($uri))
->setPath(null)
->setFragment(null)
- ->setQueryParams(array());
+ ->removeAllQueryParams();
$uri = (string)$uri;
if (preg_match('/[ ;\']/', $uri)) {
diff --git a/src/applications/auth/provider/PhabricatorAuthProvider.php b/src/applications/auth/provider/PhabricatorAuthProvider.php
--- a/src/applications/auth/provider/PhabricatorAuthProvider.php
+++ b/src/applications/auth/provider/PhabricatorAuthProvider.php
@@ -447,7 +447,7 @@
$uri = $attributes['uri'];
$uri = new PhutilURI($uri);
$params = $uri->getQueryParamsAsPairList();
- $uri->setQueryParams(array());
+ $uri->removeAllQueryParams();
$content = array($button);
diff --git a/src/applications/files/controller/PhabricatorFileDataController.php b/src/applications/files/controller/PhabricatorFileDataController.php
--- a/src/applications/files/controller/PhabricatorFileDataController.php
+++ b/src/applications/files/controller/PhabricatorFileDataController.php
@@ -135,7 +135,7 @@
$request_uri = id(clone $request->getAbsoluteRequestURI())
->setPath(null)
->setFragment(null)
- ->setQueryParams(array());
+ ->removeAllQueryParams();
$response->addContentSecurityPolicyURI(
'object-src',

File Metadata

Mime Type
text/plain
Expires
Sat, Mar 29, 7:53 PM (1 w, 3 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7721647
Default Alt Text
D20153.id.diff (1 KB)

Event Timeline

Phabricator · Built by Phacility