Page MenuHomePhabricator

Let "phlog()" log Throwables
ClosedPublic

Authored by epriestley on Feb 11 2019, 9:18 PM.
Tags
None
Referenced Files
F15410591: D20143.id48087.diff
Wed, Mar 19, 7:37 AM
F15407028: D20143.id.diff
Tue, Mar 18, 3:14 PM
F15400501: D20143.id48102.diff
Mon, Mar 17, 12:05 PM
F15397055: D20143.diff
Sun, Mar 16, 5:52 PM
F15375995: D20143.id48087.diff
Thu, Mar 13, 1:09 AM
Unknown Object (File)
Feb 21 2025, 1:55 PM
Unknown Object (File)
Feb 9 2025, 1:38 PM
Unknown Object (File)
Feb 9 2025, 11:09 AM
Subscribers
None
Tokens
"100" token, awarded by joshuaspence.

Details

Summary

Ref T13250. If you "phlog()" a Throwable, it doesn't recognize that it's an exception and sends you down the "unknown type of object" pathway. You get a one-line "Object Error" message in the log.

Instead, treat it more like an Exception and log a message + stack trace.

Test Plan

Logged some Throwables, got sensible information about them.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Feb 11 2019, 11:11 PM

It looks like passing a Throwable as $previous is actually fine everywhere (https://3v4l.org/U2B1v) but it doesn't really matter and I'm sure if we do it they'll break it in PHP 7.4 or something so ¯\_(ツ)_/¯

This revision was automatically updated to reflect the committed changes.