Page MenuHomePhabricator

Let "phlog()" log Throwables
ClosedPublic

Authored by epriestley on Feb 11 2019, 9:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 3:01 AM
Unknown Object (File)
Fri, Apr 19, 3:01 AM
Unknown Object (File)
Fri, Apr 19, 3:01 AM
Unknown Object (File)
Wed, Apr 17, 2:46 PM
Unknown Object (File)
Thu, Apr 11, 7:05 AM
Unknown Object (File)
Thu, Apr 11, 4:12 AM
Unknown Object (File)
Wed, Apr 10, 9:01 AM
Unknown Object (File)
Wed, Apr 3, 7:47 AM
Subscribers
None
Tokens
"100" token, awarded by joshuaspence.

Details

Summary

Ref T13250. If you "phlog()" a Throwable, it doesn't recognize that it's an exception and sends you down the "unknown type of object" pathway. You get a one-line "Object Error" message in the log.

Instead, treat it more like an Exception and log a message + stack trace.

Test Plan

Logged some Throwables, got sensible information about them.

Diff Detail

Repository
rPHU libphutil
Branch
throwable5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21926
Build 29940: Run Core Tests
Build 29939: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Feb 11 2019, 11:11 PM

It looks like passing a Throwable as $previous is actually fine everywhere (https://3v4l.org/U2B1v) but it doesn't really matter and I'm sure if we do it they'll break it in PHP 7.4 or something so ¯\_(ツ)_/¯

This revision was automatically updated to reflect the committed changes.