Page MenuHomePhabricator

Prepare owners package audit rules to become more flexible
ClosedPublic

Authored by epriestley on Feb 7 2019, 4:19 PM.
Tags
None
Referenced Files
F15414683: D20124.id.diff
Thu, Mar 20, 1:56 AM
F15389792: D20124.diff
Sat, Mar 15, 5:39 AM
F15383721: D20124.id.diff
Fri, Mar 14, 5:40 PM
F15312539: D20124.id48043.diff
Thu, Mar 6, 3:11 PM
F15283662: D20124.diff
Tue, Mar 4, 8:12 AM
Unknown Object (File)
Mon, Mar 3, 7:37 PM
Unknown Object (File)
Fri, Feb 21, 5:23 AM
Unknown Object (File)
Fri, Feb 21, 5:19 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13244. See PHI1055. (Earlier, see D20091 and PHI1047.) Previously, we expanded the Owners package autoreview rules from "Yes/No" to several "Review (Blocking) If Non-Owner Author Not Subscribed via Package" kinds of rules. The sky didn't fall and this feature didn't turn into "Herald-in-Owners", so I'm comfortable doing something similar to the "Audit" rules.

PHI1055 is a request for a way to configure slightly different audit behavior, and expanding the options seems like a good approach to satisfy the use case.

Prepare to add more options by moving everything into a class that defines all the behavior of different states, and converting the "0/1" boolean column to a text column.

Test Plan
  • Created several packages, some with and some without auditing.
  • Inspected database for: package state; and associated transactions.
  • Ran the migrations.
  • Inspected database to confirm that state and transactions migrated correctly.
  • Reviewed transaction logs.
  • Created and edited packages and audit state.
  • Viewed the "Package List" element in Diffusion.
  • Pulled package information with owners.search, got sensible results.
  • Edited package audit status with owners.edit.

Diff Detail

Repository
rP Phabricator
Branch
audit1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21880
Build 29869: Run Core Tests
Build 29868: arc lint + arc unit