Page MenuHomePhabricator

Statically detect "continue" inside "switch"
ClosedPublic

Authored by epriestley on Dec 22 2018, 1:44 PM.
Tags
None
Referenced Files
F15392808: D19931.diff
Sat, Mar 15, 5:42 PM
F15383832: D19931.id47571.diff
Fri, Mar 14, 6:06 PM
F15338939: D19931.id47571.diff
Sun, Mar 9, 1:34 PM
Unknown Object (File)
Mon, Feb 24, 2:26 AM
Unknown Object (File)
Thu, Feb 20, 9:36 PM
Unknown Object (File)
Feb 12 2025, 2:49 AM
Unknown Object (File)
Feb 9 2025, 6:50 AM
Unknown Object (File)
Feb 9 2025, 6:50 AM
Subscribers
None

Details

Summary

See 30 prior patches. This is a fatal in PHP7, let's just hunt these down.

Test Plan

Ran unit tests. See next diff for results.

Diff Detail

Repository
rARC Arcanist
Branch
lint1
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 21424
Build 29178: Run Core Tests
Build 29177: arc lint + arc unit

Unit TestsFailed

TimeTest
691 msArcanistJSHintLinterTestCase::Unknown Unit Message ("")
In 'jshint.lint-test', expected lint to raise error on line 9 at char 0, but no error was raised. Actually raised: warning at line 3, char 8: W033 JSHintW033 error at line 7, char 1: E019 JSHintE019
47 msArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
7 assertions passed.
29 msArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
7 assertions passed.
26 msArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("")
3 assertions passed.
12 msArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("")
3 assertions passed.
View Full Test Results (1 Failed · 294 Passed · 66 Skipped)