Page MenuHomePhabricator

Statically detect "continue" inside "switch"
ClosedPublic

Authored by epriestley on Dec 22 2018, 1:44 PM.

Details

Summary

See 30 prior patches. This is a fatal in PHP7, let's just hunt these down.

Test Plan

Ran unit tests. See next diff for results.

Diff Detail

Repository
rARC Arcanist
Branch
lint1
Lint
Lint OK
Unit
Unit Test Errors
Build Status
Buildable 21424
Build 29178: Run Core Tests
Build 29177: arc lint + arc unit

Unit TestsFailed

Excuse: JSHint version issue.
TimeTest
691 msArcanistJSHintLinterTestCase::Unknown Unit Message ("")
In 'jshint.lint-test', expected lint to raise error on line 9 at char 0, but no error was raised. Actually raised: warning at line 3, char 8: W033 JSHintW033 error at line 7, char 1: E019 JSHintE019
47 msArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
7 assertions passed.
29 msArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
7 assertions passed.
26 msArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("")
3 assertions passed.
12 msArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("")
3 assertions passed.
View Full Test Results (1 Failed · 294 Passed · 66 Skipped)

Event Timeline

epriestley created this revision.Dec 22 2018, 1:44 PM
epriestley requested review of this revision.Dec 22 2018, 1:45 PM
epriestley updated this revision to Diff 47571.Dec 22 2018, 2:17 PM
  • More robust replacement logic.
amckinley accepted this revision.Dec 24 2018, 9:25 PM
This revision is now accepted and ready to land.Dec 24 2018, 9:25 PM
This revision was automatically updated to reflect the committed changes.