Paths

Table of Contentst

Differential D19913

Give Pholio Images an authorPHID and use ExtendedPolicies to implement policy behavior
ClosedPublic
Actions

Authored by epriestley on Dec 19 2018, 12:04 AM.

Tags

None

Referenced Files

	F14739307: D19913.diff
	Sun, Jan 19, 6:43 PM

	Unknown Object (File)
	Fri, Jan 17, 3:45 PM

	Unknown Object (File)
	Fri, Jan 17, 3:20 PM

	Unknown Object (File)
	Fri, Jan 10, 11:16 PM

	Unknown Object (File)
	Wed, Jan 1, 4:44 AM

	Unknown Object (File)
	Wed, Jan 1, 4:43 AM

	Unknown Object (File)
	Wed, Jan 1, 4:43 AM

	Unknown Object (File)
	Fri, Dec 27, 12:54 PM

Subscribers

Restricted Owners Package

Details

Reviewers

Maniphest Tasks

T11351: Move Pholio to EditEngine and modern APIs

Commits

rPaa3b2ec5dcd0: Give Pholio Images an authorPHID and use ExtendedPolicies to implement policy…

Summary

Depends on D19912. Ref T11351. Images currently use getMock()->getPolicy() stuff to define policies. This causes bugs with object policies like "Subscribers", since the policy engine tries to evaluate the subscribers for the image when the intent is to evaluate the subscribers for the mock.

Move this to ExtendedPolicies to fix the behavior, and give Images sensible policy behavior when they aren't attached to a mock (specifically: only the user who created the image can see it).

Test Plan

Applied migrations, created and edited mocks and images without anything blowing up. Set mock visibility to "Subscribers", everything worked great.

Diff Detail

Repository

Branch

pholio4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21383
Build 29117: Run Core Tests
Build 29116: arc lint + arc unit

Event Timeline

epriestley created this revision.Dec 19 2018, 12:04 AM

Owners added a subscriber: Restricted Owners Package.Dec 19 2018, 12:04 AM

Harbormaster completed remote builds in B21383: Diff 47529.Dec 19 2018, 12:05 AM

epriestley requested review of this revision.Dec 19 2018, 12:05 AM

An actual bug which this fixes which no one has ever reported AFAIK but which reproduces pretty easily:

Set a mock visibility to "Subscribers".
Add "alice" as a subscriber.
Mock author is anyone else.
View mock as "alice".

Prior to this diff, Alice can't see the images in the mock. After this diff, she can.

amckinley accepted this revision.Dec 19 2018, 12:16 AM

This revision is now accepted and ready to land.Dec 19 2018, 12:16 AM

Closed by commit rPaa3b2ec5dcd0: Give Pholio Images an authorPHID and use ExtendedPolicies to implement policy… (authored by epriestley). · Explain WhyDec 19 2018, 6:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20181218.pholio.01.imageauthor.sql

2 lines

src/

__phutil_library_map__.php

applications/

pholio/

controller/

PholioImageUploadController.php

1 line

PholioMockEditController.php

2 lines

PholioMockViewController.php

19 lines

lipsum/

PhabricatorPholioMockTestDataGenerator.php

1 line

storage/

PholioImage.php

46 lines

Diff 47529

resources/sql/autopatches/20181218.pholio.01.imageauthor.sql

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/pholio/controller/PholioImageUploadController.php

Loading...

src/applications/pholio/controller/PholioMockEditController.php

Loading...

src/applications/pholio/controller/PholioMockViewController.php

Loading...

src/applications/pholio/lipsum/PhabricatorPholioMockTestDataGenerator.php

Loading...

src/applications/pholio/storage/PholioImage.php

Loading...