Page MenuHomePhabricator

Add a basic web UI for intracluster sync logs
ClosedPublic

Authored by epriestley on Nov 8 2018, 6:17 PM.
Tags
None
Referenced Files
F15376372: D19799.diff
Thu, Mar 13, 3:05 AM
F15368574: D19799.diff
Wed, Mar 12, 2:55 AM
F15367307: D19799.id47280.diff
Tue, Mar 11, 4:59 PM
F15308819: D19799.id47281.diff
Thu, Mar 6, 6:41 AM
F15308810: D19799.id47280.diff
Thu, Mar 6, 6:41 AM
F15308807: D19799.id47273.diff
Thu, Mar 6, 6:41 AM
F15308806: D19799.id.diff
Thu, Mar 6, 6:41 AM
F15308805: D19799.diff
Thu, Mar 6, 6:40 AM
Subscribers
None

Details

Summary

Depends on D19798. Ref T13216. This puts at least a basic UI on top of sync logs.

Test Plan

Viewed logs from the web UI and exported data. Note that these syncs are somewhat simulated since I my local cluster is somewhat-faked (i.e., not actually multiple machines).

Screen Shot 2018-11-08 at 10.16.57 AM.png (1×2 px, 359 KB)

Diff Detail

Repository
rP Phabricator
Branch
rlog3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21128
Build 28724: Run Core Tests
Build 28723: arc lint + arc unit

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 8 2018, 6:18 PM
Harbormaster failed remote builds in B21121: Diff 47273!

Failing because of phutil_microseconds_since(...).

amckinley added inline comments.
src/applications/diffusion/query/DiffusionSyncLogSearchEngine.php
69–74

Should these be something other than PhabricatorPHIDExportField?

101

Could this actually happen, or is this just being very defensive?

src/applications/diffusion/view/DiffusionSyncLogListView.php
22

Same as above.

This revision is now accepted and ready to land.Nov 9 2018, 7:27 PM
epriestley added inline comments.
src/applications/diffusion/query/DiffusionSyncLogSearchEngine.php
69–74

Ah, yep. Thanks!

101

Can't happen -- I overlooked this when copy/pasting pull logs. A pull may not have a valid repository (e.g., git pull <does-not-exist.git> effectively 404s and has no corresponding repository) but a sync may not, and SyncEventQuery does not load logs with an invalid repository.

  • Remove if (repository) checks -- sync logs loaded by SyncEventQuery will always have a valid repository object attached.
  • Fix export type of version columns.
This revision was automatically updated to reflect the committed changes.