Page MenuHomePhabricator

Add a basic web UI for intracluster sync logs
ClosedPublic

Authored by epriestley on Nov 8 2018, 6:17 PM.
Tags
None
Referenced Files
F13209856: D19799.diff
Fri, May 17, 2:34 AM
F13174783: D19799.id47280.diff
Wed, May 8, 1:08 AM
Unknown Object (File)
Mon, May 6, 10:19 AM
Unknown Object (File)
Fri, May 3, 8:43 AM
Unknown Object (File)
Thu, Apr 25, 2:32 AM
Unknown Object (File)
Wed, Apr 24, 1:24 PM
Unknown Object (File)
Fri, Apr 19, 8:06 PM
Unknown Object (File)
Mar 19 2024, 10:34 PM
Subscribers
None

Details

Summary

Depends on D19798. Ref T13216. This puts at least a basic UI on top of sync logs.

Test Plan

Viewed logs from the web UI and exported data. Note that these syncs are somewhat simulated since I my local cluster is somewhat-faked (i.e., not actually multiple machines).

Screen Shot 2018-11-08 at 10.16.57 AM.png (1×2 px, 359 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 8 2018, 6:18 PM
Harbormaster failed remote builds in B21121: Diff 47273!

Failing because of phutil_microseconds_since(...).

amckinley added inline comments.
src/applications/diffusion/query/DiffusionSyncLogSearchEngine.php
69–74

Should these be something other than PhabricatorPHIDExportField?

101

Could this actually happen, or is this just being very defensive?

src/applications/diffusion/view/DiffusionSyncLogListView.php
22

Same as above.

This revision is now accepted and ready to land.Nov 9 2018, 7:27 PM
epriestley added inline comments.
src/applications/diffusion/query/DiffusionSyncLogSearchEngine.php
69–74

Ah, yep. Thanks!

101

Can't happen -- I overlooked this when copy/pasting pull logs. A pull may not have a valid repository (e.g., git pull <does-not-exist.git> effectively 404s and has no corresponding repository) but a sync may not, and SyncEventQuery does not load logs with an invalid repository.

  • Remove if (repository) checks -- sync logs loaded by SyncEventQuery will always have a valid repository object attached.
  • Fix export type of version columns.
This revision was automatically updated to reflect the committed changes.