Page MenuHomePhabricator

Fix an errant "switch ... continue"
ClosedPublic

Authored by epriestley on Nov 5 2018, 12:42 PM.
Tags
None
Referenced Files
F19103314: D19772.diff
Dec 5 2025, 9:29 AM
F18846357: D19772.id47231.diff
Oct 29 2025, 6:41 PM
F18838305: D19772.id.diff
Oct 27 2025, 10:10 AM
F18826583: D19772.id47234.diff
Oct 24 2025, 4:43 AM
F18822892: D19772.diff
Oct 23 2025, 9:08 AM
F18798667: D19772.id47231.diff
Oct 17 2025, 7:36 AM
F18698661: D19772.diff
Sep 27 2025, 11:42 AM
F18568679: D19772.id47234.diff
Sep 10 2025, 12:21 AM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/unhandled-exception-on-create-task/2062.

This construction has the same behavior as "switch ... break" but is unconventional. PHP 7.3 started warning about it because it's likely a mistake.

Test Plan

Created a task, edited a task owner. The new code is functionally identical to the old code.

Diff Detail

Repository
rP Phabricator
Branch
break1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21080
Build 28645: Run Core Tests
Build 28644: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Nov 5 2018, 3:32 PM
This revision was automatically updated to reflect the committed changes.