Differential D19772

Fix an errant "switch ... continue"
ClosedPublic
Actions

Authored by epriestley on Nov 5 2018, 12:42 PM.

Tags

None

Referenced Files

	F14759898: D19772.diff
	Wed, Jan 22, 2:48 PM

	F14755217: D19772.id47234.diff
	Tue, Jan 21, 3:57 PM

	Unknown Object (File)
	Tue, Jan 21, 11:57 AM

	Unknown Object (File)
	Fri, Jan 3, 10:00 PM

	Unknown Object (File)
	Dec 22 2024, 5:06 AM

	Unknown Object (File)
	Dec 9 2024, 3:51 PM

	Unknown Object (File)
	Dec 8 2024, 4:37 PM

	Unknown Object (File)
	Dec 1 2024, 3:53 PM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rPd2316e802568: Fix an errant "switch ... continue"

Summary

See https://discourse.phabricator-community.org/t/unhandled-exception-on-create-task/2062.

This construction has the same behavior as "switch ... break" but is unconventional. PHP 7.3 started warning about it because it's likely a mistake.

Test Plan

Created a task, edited a task owner. The new code is functionally identical to the old code.

Diff Detail

Repository

rP Phabricator

Branch

break1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21080
Build 28645: Run Core Tests
Build 28644: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 5 2018, 12:42 PM

Harbormaster completed remote builds in B21080: Diff 47231.Nov 5 2018, 12:43 PM

epriestley requested review of this revision.Nov 5 2018, 12:43 PM

amckinley accepted this revision.Nov 5 2018, 3:32 PM

This revision is now accepted and ready to land.Nov 5 2018, 3:32 PM

Closed by commit rPd2316e802568: Fix an errant "switch ... continue" (authored by epriestley). · Explain WhyNov 5 2018, 6:26 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

editor/

ManiphestTransactionEditor.php

2 lines

Diff 47231

View Options

src/applications/maniphest/editor/ManiphestTransactionEditor.php

Fix an errant "switch ... continue"ClosedPublicActions