Differential D19759

Remove unicode marks for "Accept/Raise Concern" in Audit
ClosedPublic
Actions

Authored by epriestley on Oct 25 2018, 11:53 AM.

Details

Reviewers

amckinley

Maniphest Tasks

T13210: Plans: 2018 Week 41-44 Bonus Content

Commits

rP61ec43420808: Remove unicode marks for "Accept/Raise Concern" in Audit

Summary

Ref T13210. The comment action dropdown for audits has a heavy checkmark next to "Accept" and a heavy "X" next to "Raise Concern".

We previously removed similar marks in Differential in D19405 and that seems to have gone fine. For consistency, remove these too.

Test Plan

Viewed the comment action dropdown, no longer saw checkmark and X-mark.

Diff Detail

Repository

rP Phabricator

Branch

audit1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21038
Build 28585: Run Core Tests
Build 28584: arc lint + arc unit

Event Timeline

epriestley created this revision.Oct 25 2018, 11:53 AM

Harbormaster completed remote builds in B21038: Diff 47193.Oct 25 2018, 11:54 AM

epriestley requested review of this revision.Oct 25 2018, 11:54 AM

amckinley accepted this revision.Oct 26 2018, 9:27 PM

This revision is now accepted and ready to land.Oct 26 2018, 9:27 PM

Closed by commit rP61ec43420808: Remove unicode marks for "Accept/Raise Concern" in Audit (authored by epriestley). · Explain WhyOct 27 2018, 2:19 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

xaction/

DiffusionCommitAcceptTransaction.php

2 lines

DiffusionCommitConcernTransaction.php

2 lines

Diff 47193

View Options

src/applications/diffusion/xaction/DiffusionCommitAcceptTransaction.php