Page MenuHomePhabricator

Remove unusual unicode marks in Differential action dropdown
ClosedPublic

Authored by epriestley on Apr 25 2018, 1:24 PM.
Tags
None
Referenced Files
F18839430: D19405.id46424.diff
Mon, Oct 27, 4:16 PM
F18725173: D19405.diff
Sep 30 2025, 4:51 AM
F18698243: D19405.diff
Sep 27 2025, 11:01 AM
F18509595: D19405.id.diff
Sep 5 2025, 3:29 AM
F18502799: D19405.diff
Sep 4 2025, 10:39 PM
F18469917: D19405.id46414.diff
Sep 2 2025, 5:19 PM
F18466410: D19405.id46424.diff
Sep 2 2025, 9:44 AM
F18466178: D19405.diff
Sep 2 2025, 9:01 AM
Subscribers
None

Details

Summary

See https://twitter.com/HayleyCAnderson/status/988873585363009536.

Currently, the action dropdown in Differential shows a heavy "X" after "Request Changes" and a heavy checkmark after "Accept Revision".

Although I'm not convinced that the messaging around "Request Changes" is too strong, I do think these marks are out of place in modern Differential. They came from a simpler time when this dropdown had fewer actions, but feel a little weird and inconsistent to me in the modern UI.

Let's try getting rid of them and see how it goes?

Test Plan
  • Viewed these actions in the dropdown, no longer saw the mark icons.
  • Grepped for these unicode sequences without getting any other hits.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable