Page MenuHomePhabricator

Remove unusual unicode marks in Differential action dropdown
ClosedPublic

Authored by epriestley on Apr 25 2018, 1:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 1:51 AM
Unknown Object (File)
Oct 19 2024, 1:31 AM
Unknown Object (File)
Oct 18 2024, 9:26 AM
Unknown Object (File)
Oct 16 2024, 11:48 AM
Unknown Object (File)
Oct 1 2024, 9:09 PM
Unknown Object (File)
Sep 4 2024, 1:12 AM
Unknown Object (File)
Sep 4 2024, 1:12 AM
Unknown Object (File)
Sep 4 2024, 12:45 AM
Subscribers
None

Details

Summary

See https://twitter.com/HayleyCAnderson/status/988873585363009536.

Currently, the action dropdown in Differential shows a heavy "X" after "Request Changes" and a heavy checkmark after "Accept Revision".

Although I'm not convinced that the messaging around "Request Changes" is too strong, I do think these marks are out of place in modern Differential. They came from a simpler time when this dropdown had fewer actions, but feel a little weird and inconsistent to me in the modern UI.

Let's try getting rid of them and see how it goes?

Test Plan
  • Viewed these actions in the dropdown, no longer saw the mark icons.
  • Grepped for these unicode sequences without getting any other hits.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable