Page MenuHomePhabricator

Fix `packages(project)` to work properly and add it to "MailableFunctionDatasource"
ClosedPublic

Authored by epriestley on Oct 19 2018, 11:46 AM.
Tags
None
Referenced Files
F15474537: D19747.id47178.diff
Sun, Apr 6, 9:45 AM
F15472987: D19747.diff
Sat, Apr 5, 6:17 PM
F15446243: D19747.id.diff
Thu, Mar 27, 5:54 PM
F15441108: D19747.diff
Wed, Mar 26, 4:27 PM
F15432447: D19747.id.diff
Mon, Mar 24, 6:12 PM
F15413983: D19747.diff
Wed, Mar 19, 10:18 PM
F15412696: D19747.id.diff
Wed, Mar 19, 2:27 PM
F15386032: D19747.id.diff
Fri, Mar 14, 11:55 PM
Subscribers
None

Details

Summary

Ref T13210. See PHI937. This function datasource isn't quite implemented correctly: it doesn't resolve package(project) properly, since the logic only handles users.

This blames back to D14013, where it looks like packages(..) was added mostly as a general nice-to-have as part of a larger modernization change.

Test Plan

Ran a packages(project) query in Differential, got accurate results (previously: no results).

Diff Detail

Repository
rP Phabricator
Branch
packages1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21021
Build 28556: Run Core Tests
Build 28555: arc lint + arc unit