Page MenuHomePhabricator

Fix `packages(project)` to work properly and add it to "MailableFunctionDatasource"
ClosedPublic

Authored by epriestley on Oct 19 2018, 11:46 AM.
Tags
None
Referenced Files
F13186779: D19747.diff
Sat, May 11, 3:59 AM
F13180612: D19747.id.diff
Thu, May 9, 1:27 AM
Unknown Object (File)
Tue, May 7, 7:11 AM
Unknown Object (File)
Sat, May 4, 4:06 AM
Unknown Object (File)
Fri, May 3, 5:23 AM
Unknown Object (File)
Wed, May 1, 1:19 AM
Unknown Object (File)
Tue, Apr 30, 6:12 AM
Unknown Object (File)
Mon, Apr 29, 5:00 PM
Subscribers
None

Details

Summary

Ref T13210. See PHI937. This function datasource isn't quite implemented correctly: it doesn't resolve package(project) properly, since the logic only handles users.

This blames back to D14013, where it looks like packages(..) was added mostly as a general nice-to-have as part of a larger modernization change.

Test Plan

Ran a packages(project) query in Differential, got accurate results (previously: no results).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable