Page MenuHomePhabricator

Fix `packages(project)` to work properly and add it to "MailableFunctionDatasource"
ClosedPublic

Authored by epriestley on Oct 19 2018, 11:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 5:25 AM
Unknown Object (File)
Wed, Apr 17, 3:14 AM
Unknown Object (File)
Sat, Apr 13, 1:21 PM
Unknown Object (File)
Fri, Apr 12, 11:22 PM
Unknown Object (File)
Thu, Apr 4, 7:42 PM
Unknown Object (File)
Sat, Mar 30, 6:36 PM
Unknown Object (File)
Thu, Mar 28, 4:51 PM
Unknown Object (File)
Wed, Mar 27, 12:48 AM
Subscribers
None

Details

Summary

Ref T13210. See PHI937. This function datasource isn't quite implemented correctly: it doesn't resolve package(project) properly, since the logic only handles users.

This blames back to D14013, where it looks like packages(..) was added mostly as a general nice-to-have as part of a larger modernization change.

Test Plan

Ran a packages(project) query in Differential, got accurate results (previously: no results).

Diff Detail

Repository
rP Phabricator
Branch
packages1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21021
Build 28556: Run Core Tests
Build 28555: arc lint + arc unit