Differential D19736

Add support for anonymous class
ClosedPublic
Actions

Authored by wjiang on Oct 8 2018, 12:51 AM.

Details

Reviewers

joshuaspence
thaiphv
epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4334: Support PHP5.4+ syntax in XHPAST

Commits

rPHU8c1091dc9892: (stable) Promote 2018 Week 41
rPHU603209bb1756: Add support for anonymous class

Summary

Ref T4334. Adds support for anonymous class, which is supported by PHP 7.0.

Test Plan

Added test cases.

Diff Detail

Repository

rPHU libphutil

Branch

master

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	support/xhpast/xhpast.cpp:0	Cppcheck	toomanyconfigs

Unit

Tests Passed

Build Status

Buildable 20999
Build 28525: arc lint + arc unit

Event Timeline

wjiang created this revision.Oct 8 2018, 12:51 AM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 8 2018, 12:51 AM

Herald added subscribers: Firehed, epriestley. · View Herald Transcript

wjiang requested review of this revision.Oct 8 2018, 12:51 AM

Harbormaster completed remote builds in B20999: Diff 47156.Oct 8 2018, 12:51 AM

wjiang added a reviewer: thaiphv.Oct 8 2018, 12:53 AM

joshuaspence accepted this revision.Oct 8 2018, 12:54 AM

epriestley accepted this revision.Oct 8 2018, 2:05 PM

This revision is now accepted and ready to land.Oct 8 2018, 2:05 PM

Herald added a subscriber: Korvin. · View Herald TranscriptOct 8 2018, 2:05 PM

Automated landing didn't work so I'll do it the old-fashioned way.

Closed by commit rPHU603209bb1756: Add support for anonymous class (authored by wjiang, committed by joshuaspence). · Explain WhyOct 8 2018, 11:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

xhpast/

__tests__/

data/

anonymous_class.php.test

599 lines

bin/

PhutilXHPASTBinary.php

2 lines

support/

xhpast/

15 lines

2 lines

Diff 47156

View Options

src/parser/xhpast/tests/data/anonymous_class.php.test

View Options

src/parser/xhpast/bin/PhutilXHPASTBinary.php

View Options

support/xhpast/parser.y

View Options

support/xhpast/parser.yacc.cpp

View Options

support/xhpast/scanner.lex.hpp

View Options

support/xhpast/scanner.lex.cpp

View Options

Add support for anonymous classClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47156

src/parser/xhpast/__tests__/data/anonymous_class.php.test

src/parser/xhpast/bin/PhutilXHPASTBinary.php

support/xhpast/parser.y

support/xhpast/parser.yacc.cpp

support/xhpast/scanner.lex.hpp

support/xhpast/scanner.lex.cpp

support/xhpast/xhpast.cpp

Add support for anonymous class
ClosedPublic
Actions

Revision Contents
Changeset List

src/parser/xhpast/tests/data/anonymous_class.php.test