Page MenuHomePhabricator
Differential D19686

[Wilds] Rename "--load-phutil-library" to "--library" in new `arc`
ClosedPublic
Actions

Authored by epriestley on Sep 18 2018, 5:18 PM.
Tags
None
Referenced Files
F15466088: D19686.id47060.diff
Thu, Apr 3, 1:26 AM
F15460975: D19686.id.diff
Tue, Apr 1, 4:00 AM
F15459352: D19686.id.diff
Mon, Mar 31, 12:07 PM
F15458723: D19686.diff
Mon, Mar 31, 6:34 AM
F15399851: D19686.diff
Mon, Mar 17, 8:06 AM
F15319348: D19686.diff
Thu, Mar 6, 9:07 PM
F15319347: D19686.diff
Thu, Mar 6, 9:07 PM
F15317009: D19686.id47039.diff
Thu, Mar 6, 7:10 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13098: Plans: Arcanist toolsets and extensions
Commits
rARCd62830195cfa: [Wilds] Rename "--load-phutil-library" to "--library" in new `arc`
Summary

Ref T13098. The name of this option is needlessly obscure/verbose, and we now require it come first so it should be unambiguous even if we add arc borrow-a-book later.

Test Plan

Grepped for --load-phutil-library.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 20852
Build 28363: Run Core Tests

Event Timeline

epriestley created this revision.Sep 18 2018, 5:18 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Sep 18 2018, 5:18 PM
Harbormaster failed remote builds in B20852: Diff 47039!
epriestley requested review of this revision.Sep 18 2018, 5:22 PM
epriestley mentioned this in T13098: Plans: Arcanist toolsets and extensions.
amckinley accepted this revision.Sep 19 2018, 6:43 PM
This revision is now accepted and ready to land.Sep 19 2018, 6:43 PM
Closed by commit rARCd62830195cfa: [Wilds] Rename "--load-phutil-library" to "--library" in new `arc` (authored by epriestley). · Explain WhySep 21 2018, 10:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
scripts/
init/
6 lines

Diff 47039

View Options

scripts/init/init-arcanist.php

Loading...
Phabricator · Built by Phacility