[Wilds] Rename "--load-phutil-library" to "--library" in new `arc`
ClosedPublic
Actions

Authored by epriestley on Sep 18 2018, 5:18 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13098: Plans: Arcanist toolsets and extensions

Commits

rARCd62830195cfa: [Wilds] Rename "--load-phutil-library" to "--library" in new `arc`

Summary

Ref T13098. The name of this option is needlessly obscure/verbose, and we now require it come first so it should be unambiguous even if we add arc borrow-a-book later.

Test Plan

Grepped for --load-phutil-library.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 20852
Build 28363: Run Core Tests

Event Timeline

epriestley created this revision.Sep 18 2018, 5:18 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 18 2018, 5:18 PM

Harbormaster failed remote builds in B20852: Diff 47039!

epriestley requested review of this revision.Sep 18 2018, 5:22 PM

epriestley mentioned this in T13098: Plans: Arcanist toolsets and extensions.

amckinley accepted this revision.Sep 19 2018, 6:43 PM

This revision is now accepted and ready to land.Sep 19 2018, 6:43 PM

Closed by commit rARCd62830195cfa: [Wilds] Rename "--load-phutil-library" to "--library" in new `arc` (authored by epriestley). · Explain WhySep 21 2018, 10:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

scripts/

init/

init-arcanist.php

6 lines

Diff 47039

View Options

scripts/init/init-arcanist.php

[Wilds] Rename "--load-phutil-library" to "--library" in new `arc`ClosedPublicActions