HomePhabricator

[Wilds] Sort of make "arc help" work again

Description

[Wilds] Sort of make "arc help" work again

Summary:
Ref T13098. This makes "arc help" kind-of sort-of work again.

Previously, "arc help" was completely custom and hard-coded. Now it just proxies the generic libphutil "help" workflow. The two flows are substantially similar, although old arc help was a little more brief than the new version is. The old arc help --full was more similar to the default:

CommandOld BehaviorNew Behavior
arcTells you to run arc help.Plan: make this a bit richer and give a quick summary of workflows.
arc helpGives you a summary of workflows.Gives you a detailed list of workflows.
arc help --fullGives you a detailed list of workflows.No such flag.
arc --helpSame as arc help.Same as arc. Plan: same as arc help.
arc help <workflow>Full workflow help.Full workflow help.
arc <workflow> --helpAs above.As above.

Overall this is largely the same and lets us delete a bunch of code.

Test Plan:
Ran arc, arc help, arc --help, arc --help diff, arc diff --help, arc help diff, arc help help.

These commands largely do something sensible now, with caveats per above.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13098

Differential Revision: https://secure.phabricator.com/D19679

Details

Provenance
epriestleyAuthored on Sep 14 2018, 7:47 PM
epriestleyPushed on Sep 21 2018, 10:58 PM
Reviewer
amckinley
Differential Revision
D19679: [Wilds] Sort of make "arc help" work again
Parents
rARC8e51f89c794b: [Wilds] Make "arc liberate" run in the untamed wilds
Branches
Unknown
Tags
Unknown
Tasks
T13098: Plans: Arcanist toolsets and extensions
Build Status
Buildable 20870
Build 28382: Run Core Tests