Differential D19683

Fix Phriction rendering for initial install and 404 pages
ClosedPublic
Actions

Authored by epriestley on Sep 17 2018, 10:18 PM.

Details

Reviewers

Maniphest Tasks

T13202: Plans: 2018 Week 38-40 Bonus Content

Commits

rP8ab7859d85cc: (stable) Fix Phriction rendering for initial install and 404 pages
rP5ba66e56fd54: Fix Phriction rendering for initial install and 404 pages

Summary

Depends on D19682. Ref T13202. We currently fatal when trying to render a timeline if:

an install is fresh, so there are no pages yet, and you look at "/w/"; or
you're looking at a Phriction page which doesn't exist (yet) like "/w/aadsflknadsflnf/".

Rendering a timeline and comment area doesn't make sense in these cases, so don't render them.

Test Plan

Hit both cases described above, got "new/empty page" prompts instead of fatals.

Diff Detail

Repository

rP Phabricator

Branch

wiki2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20845
Build 28354: Run Core Tests
Build 28353: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 17 2018, 10:18 PM

Harbormaster completed remote builds in B20845: Diff 47034.Sep 17 2018, 10:20 PM

epriestley requested review of this revision.Sep 17 2018, 10:20 PM

epriestley mentioned this in D19682: Fix fatal in rendering Phriction "Moved Away" stories.Sep 18 2018, 3:01 AM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 18 2018, 3:03 AM

Closed by commit rP5ba66e56fd54: Fix Phriction rendering for initial install and 404 pages (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phriction/

controller/

PhrictionDocumentController.php

21 lines

Diff 47034

View Options

src/applications/phriction/controller/PhrictionDocumentController.php

Fix Phriction rendering for initial install and 404 pagesClosedPublicActions