Page MenuHomePhabricator

Fix Phriction rendering for initial install and 404 pages
ClosedPublic

Authored by epriestley on Sep 17 2018, 10:18 PM.
Tags
None
Referenced Files
F15454545: D19683.id47036.diff
Sat, Mar 29, 7:01 PM
F15447708: D19683.id47034.diff
Fri, Mar 28, 1:10 AM
F15438390: D19683.id.diff
Wed, Mar 26, 12:28 AM
F15436374: D19683.id47034.diff
Tue, Mar 25, 1:48 PM
F15434651: D19683.id47036.diff
Tue, Mar 25, 4:49 AM
F15432048: D19683.id47036.diff
Mon, Mar 24, 3:56 PM
F15426112: D19683.diff
Sun, Mar 23, 7:13 AM
F15399126: D19683.id47034.diff
Mon, Mar 17, 3:01 AM
Subscribers
None

Details

Summary

Depends on D19682. Ref T13202. We currently fatal when trying to render a timeline if:

  • an install is fresh, so there are no pages yet, and you look at "/w/"; or
  • you're looking at a Phriction page which doesn't exist (yet) like "/w/aadsflknadsflnf/".

Rendering a timeline and comment area doesn't make sense in these cases, so don't render them.

Test Plan

Hit both cases described above, got "new/empty page" prompts instead of fatals.

Diff Detail

Repository
rP Phabricator
Branch
wiki2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20845
Build 28354: Run Core Tests
Build 28353: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 18 2018, 3:03 AM
This revision was automatically updated to reflect the committed changes.