Differential D19668

Make Phriction diff-of-changes view draft-aware and clarify some language
ClosedPublic
Actions

Authored by epriestley on Sep 13 2018, 3:33 PM.

Tags

None

Referenced Files

	F13197278: D19668.id47004.diff
	Sun, May 12, 11:59 PM

	F13188409: D19668.diff
	Sat, May 11, 5:14 AM

	Unknown Object (File)
	Tue, May 7, 8:28 AM

	Unknown Object (File)
	Mon, May 6, 1:33 PM

	Unknown Object (File)
	Sun, May 5, 8:16 PM

	Unknown Object (File)
	Fri, May 3, 8:18 AM

	Unknown Object (File)
	Sat, Apr 27, 2:23 AM

	Unknown Object (File)
	Thu, Apr 25, 2:16 AM

View All 70 Files

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13077: Plans: Phriction modern "v3" APIs, Drafts
T13197: 2018 Week 37 Bonus Content

Commits

rP0abf29765e05: Make Phriction diff-of-changes view draft-aware and clarify some language

Summary

Ref T13077. Ref T13197. See PHI840.

In the "History > Diff/Compare" view, the button language wasn't draft-aware.
Revise language to avoid the word "Revert", since this can be ambiguous.
- "Edit this page, starting with an older version of the text" is now "Edit Older|Current|Draft Version X".
- "Mark this older version of the page as the current published version" is now "Publish Older Version".
Let the user edit the current published version, too, since this is a reasonable operation if there are drafts.

Test Plan

Navigated the history diff view, saw better button and action text.

Diff Detail

Repository

Branch

wiki7

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20815
Build 28309: Run Core Tests
Build 28308: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 13 2018, 3:33 PM

Harbormaster completed remote builds in B20815: Diff 47004.Sep 13 2018, 3:34 PM

epriestley requested review of this revision.Sep 13 2018, 3:34 PM

epriestley added a child revision: D19669: Update Phriction documentation for drafts.Sep 13 2018, 4:12 PM

amckinley accepted this revision.Sep 13 2018, 6:12 PM

This revision is now accepted and ready to land.Sep 13 2018, 6:12 PM

Closed by commit rP0abf29765e05: Make Phriction diff-of-changes view draft-aware and clarify some language (authored by epriestley). · Explain WhySep 13 2018, 9:12 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phriction/

controller/

PhrictionDiffController.php

20 lines

PhrictionDocumentController.php

2 lines

PhrictionPublishController.php

2 lines

Diff 47004

src/applications/phriction/controller/PhrictionDiffController.php

Loading...

src/applications/phriction/controller/PhrictionDocumentController.php

Loading...

src/applications/phriction/controller/PhrictionPublishController.php

Loading...