Page MenuHomePhabricator
Differential D19654

Add aural section headers for "Event Timeline", "Add Comment", and "Comment Preview"
ClosedPublic
Actions

Authored by epriestley on Sep 10 2018, 9:34 PM.
Tags
None
Referenced Files
F15538911: D19654.diff
Thu, Apr 24, 10:21 PM
F15510890: D19654.id46972.diff
Wed, Apr 16, 9:51 PM
F15458568: D19654.id46969.diff
Mar 31 2025, 4:53 AM
F15452453: D19654.id46984.diff
Mar 29 2025, 4:56 AM
F15452118: D19654.id46972.diff
Mar 29 2025, 1:55 AM
F15444305: D19654.id.diff
Mar 27 2025, 8:59 AM
F15441943: D19654.diff
Mar 26 2025, 8:41 PM
F15440479: D19654.id46969.diff
Mar 26 2025, 12:57 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13197: 2018 Week 37 Bonus Content
Commits
rP185e72c881cf: Add aural section headers for "Event Timeline", "Add Comment", and "Comment…
Summary

See PHI871. Ref T13197. These sections are only divided visually and don't have textual headers. Add aural headers.

Test Plan

Screen Shot 2018-09-10 at 2.32.40 PM.png (1×1 px, 168 KB)

Diff Detail

Repository
rP Phabricator
Branch
accheaders1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20782
Build 28260: Run Core Tests
Build 28259: arc lint + arc unit

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
applications/
transactions/
response/
8 lines
view/
7 lines
view/
phui/
10 lines
webroot/
rsrc/
js/
application/
transactions/
1 line

Diff 46972

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/transactions/response/PhabricatorApplicationTransactionResponse.php

Loading...
View Options

src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php

Loading...
View Options

src/view/phui/PHUITimelineView.php

Loading...
View Options

webroot/rsrc/js/application/transactions/behavior-comment-actions.js

Loading...
Phabricator · Built by Phacility