Differential D19654

Add aural section headers for "Event Timeline", "Add Comment", and "Comment Preview"
ClosedPublic
Actions

Authored by epriestley on Sep 10 2018, 9:34 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13197: 2018 Week 37 Bonus Content

Commits

rP185e72c881cf: Add aural section headers for "Event Timeline", "Add Comment", and "Comment…

Summary

See PHI871. Ref T13197. These sections are only divided visually and don't have textual headers. Add aural headers.

Test Plan

Screen Shot 2018-09-10 at 2.32.40 PM.png (1×1 px, 168 KB)

Diff Detail

Repository

rP Phabricator

Branch

accheaders1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20779
Build 28254: Run Core Tests
Build 28253: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 10 2018, 9:34 PM

Harbormaster completed remote builds in B20779: Diff 46969.Sep 10 2018, 9:36 PM

epriestley requested review of this revision.Sep 10 2018, 9:36 PM

Get rid of unrelated td/th changes, which are broader in scope.

Harbormaster completed remote builds in B20782: Diff 46972.Sep 10 2018, 9:46 PM

amckinley accepted this revision.Sep 11 2018, 5:51 PM

This revision is now accepted and ready to land.Sep 11 2018, 5:51 PM

Closed by commit rP185e72c881cf: Add aural section headers for "Event Timeline", "Add Comment", and "Comment… (authored by epriestley). · Explain WhySep 11 2018, 8:30 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

src/

applications/

differential/

render/

DifferentialChangesetTwoUpRenderer.php

4 lines

transactions/

response/

PhabricatorApplicationTransactionResponse.php

8 lines

view/

PhabricatorApplicationTransactionCommentView.php

7 lines

view/

phui/

PHUITimelineView.php

10 lines

webroot/

rsrc/

js/

application/

transactions/

behavior-comment-actions.js

1 line

Diff 46969

View Options

resources/celerity/map.php

View Options

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

View Options

src/applications/transactions/response/PhabricatorApplicationTransactionResponse.php

View Options

src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php

View Options

src/view/phui/PHUITimelineView.php

View Options

webroot/rsrc/js/application/transactions/behavior-comment-actions.js

Add aural section headers for "Event Timeline", "Add Comment", and "Comment Preview"ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 46969

resources/celerity/map.php

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

src/applications/transactions/response/PhabricatorApplicationTransactionResponse.php

src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php

src/view/phui/PHUITimelineView.php

webroot/rsrc/js/application/transactions/behavior-comment-actions.js

Add aural section headers for "Event Timeline", "Add Comment", and "Comment Preview"
ClosedPublic
Actions

Revision Contents
Changeset List