Page MenuHomePhabricator
Differential D19654

Add aural section headers for "Event Timeline", "Add Comment", and "Comment Preview"
ClosedPublic
Actions

Authored by epriestley on Sep 10 2018, 9:34 PM.
Tags
None
Referenced Files
F22901881: D19654.diff
Sat, Oct 17, 12:51 AM
Unknown Object (File)
Sep 1 2026, 5:43 AM
Unknown Object (File)
Aug 19 2026, 7:04 PM
Unknown Object (File)
Jun 29 2026, 5:53 PM
Unknown Object (File)
Jun 25 2026, 6:32 AM
Unknown Object (File)
Jun 23 2026, 12:58 AM
Unknown Object (File)
Jun 23 2026, 12:58 AM
Unknown Object (File)
Jun 23 2026, 12:58 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13197: 2018 Week 37 Bonus Content
Commits
rP185e72c881cf: Add aural section headers for "Event Timeline", "Add Comment", and "Comment…
Summary

See PHI871. Ref T13197. These sections are only divided visually and don't have textual headers. Add aural headers.

Test Plan

Screen Shot 2018-09-10 at 2.32.40 PM.png (1×1 px, 168 KB)

Diff Detail

Repository
rP Phabricator
Branch
accheaders1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20779
Build 28254: Run Core Tests
Build 28253: arc lint + arc unit

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
applications/
differential/
render/
4 lines
transactions/
response/
8 lines
view/
7 lines
view/
phui/
10 lines
webroot/
rsrc/
js/
application/
transactions/
1 line

Diff 46969

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

Loading...
View Options

src/applications/transactions/response/PhabricatorApplicationTransactionResponse.php

Loading...
View Options

src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php

Loading...
View Options

src/view/phui/PHUITimelineView.php

Loading...
View Options

webroot/rsrc/js/application/transactions/behavior-comment-actions.js

Loading...
Phabricator · Built by Phacility