Page MenuHomePhabricator
Differential D19631

Parse HTTP responses with empty "reason-phrase" properly in PhutilHTTPResponseParser
ClosedPublic
Actions

Authored by epriestley on Sep 4 2018, 3:27 PM.
Tags
None
Referenced Files
F19504516: D19631.diff
Fri, Jan 9, 5:16 AM
F19504496: D19631.diff
Fri, Jan 9, 5:14 AM
F19398399: D19631.id46943.diff
Sat, Dec 27, 11:29 AM
F19341177: D19631.id46943.diff
Thu, Dec 25, 11:01 PM
F18874948: D19631.id46922.diff
Nov 5 2025, 4:22 PM
F18867728: D19631.diff
Nov 4 2025, 2:18 AM
F18866620: D19631.id.diff
Nov 3 2025, 6:17 PM
F18846721: D19631.diff
Oct 29 2025, 8:45 PM
View All Files
Subscribers
None
Tokens
"Like" token, awarded by nfirmani.

Details

Reviewers
amckinley
Commits
rPHU52a394a76bc7: Parse HTTP responses with empty "reason-phrase" properly in…
Summary

Depends on D19628. This ports the fix from that change to PhutilHTTPResponseParser, which is theoretically the future of HTTP response parsing.

Test Plan

Added unit test and made it pass; this code is currently unreachable.

Diff Detail

Repository
rPHU libphutil
Branch
http2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20728
Build 28177: Run Core Tests
Build 28176: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
parser/
http/
2 lines
__tests__/
21 lines

Diff 46922

View Options

src/parser/http/PhutilHTTPResponseParser.php

Loading...
View Options

src/parser/http/__tests__/PhutilHTTPResponseParserTestCase.php

Loading...
Phabricator · Built by Phacility