Page MenuHomePhabricator
Differential D19631

Parse HTTP responses with empty "reason-phrase" properly in PhutilHTTPResponseParser
ClosedPublic
Actions

Authored by epriestley on Sep 4 2018, 3:27 PM.
Tags
None
Referenced Files
F17713553: D19631.diff
Thu, Jul 17, 2:14 PM
Unknown Object (File)
Jun 17 2025, 6:43 AM
Unknown Object (File)
Apr 23 2025, 10:12 PM
Unknown Object (File)
Apr 20 2025, 5:58 AM
Unknown Object (File)
Apr 9 2025, 9:50 PM
Unknown Object (File)
Mar 30 2025, 9:31 AM
Unknown Object (File)
Mar 27 2025, 8:03 PM
Unknown Object (File)
Mar 26 2025, 10:49 AM
View All Files
Subscribers
None
Tokens
"Like" token, awarded by nfirmani.

Details

Reviewers
amckinley
Commits
rPHU52a394a76bc7: Parse HTTP responses with empty "reason-phrase" properly in…
Summary

Depends on D19628. This ports the fix from that change to PhutilHTTPResponseParser, which is theoretically the future of HTTP response parsing.

Test Plan

Added unit test and made it pass; this code is currently unreachable.

Diff Detail

Repository
rPHU libphutil
Branch
http2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20728
Build 28177: Run Core Tests
Build 28176: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
parser/
http/
2 lines
__tests__/
21 lines

Diff 46922

View Options

src/parser/http/PhutilHTTPResponseParser.php

Loading...
View Options

src/parser/http/__tests__/PhutilHTTPResponseParserTestCase.php

Loading...
Phabricator · Built by Phacility