Page MenuHomePhabricator
Differential D19631

Parse HTTP responses with empty "reason-phrase" properly in PhutilHTTPResponseParser
ClosedPublic
Actions

Authored by epriestley on Sep 4 2018, 3:27 PM.
Tags
None
Referenced Files
F18874948: D19631.id46922.diff
Nov 5 2025, 4:22 PM
F18867728: D19631.diff
Nov 4 2025, 2:18 AM
F18866620: D19631.id.diff
Nov 3 2025, 6:17 PM
F18846721: D19631.diff
Oct 29 2025, 8:45 PM
F18832635: D19631.id46943.diff
Oct 25 2025, 10:23 PM
F18832634: D19631.id46922.diff
Oct 25 2025, 10:23 PM
F18832632: D19631.id.diff
Oct 25 2025, 10:22 PM
F18831595: D19631.diff
Oct 25 2025, 1:46 PM
View All Files
Subscribers
None
Tokens
"Like" token, awarded by nfirmani.

Details

Reviewers
amckinley
Commits
rPHU52a394a76bc7: Parse HTTP responses with empty "reason-phrase" properly in…
Summary

Depends on D19628. This ports the fix from that change to PhutilHTTPResponseParser, which is theoretically the future of HTTP response parsing.

Test Plan

Added unit test and made it pass; this code is currently unreachable.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
parser/
http/
2 lines
__tests__/
21 lines

Diff 46943

View Options

src/parser/http/PhutilHTTPResponseParser.php

Loading...
View Options

src/parser/http/__tests__/PhutilHTTPResponseParserTestCase.php

Loading...
Phabricator · Built by Phacility