Paths

Table of Contentst

Differential D19631

Parse HTTP responses with empty "reason-phrase" properly in PhutilHTTPResponseParser
ClosedPublic
Actions

Authored by epriestley on Sep 4 2018, 3:27 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Feb 22, 2:34 AM

	Unknown Object (File)
	Fri, Feb 14, 9:33 AM

	Unknown Object (File)
	Jan 30 2025, 8:21 AM

	Unknown Object (File)
	Jan 29 2025, 9:34 PM

	Unknown Object (File)
	Jan 29 2025, 1:35 PM

	Unknown Object (File)
	Jan 21 2025, 11:46 AM

	Unknown Object (File)
	Jan 21 2025, 9:54 AM

	Unknown Object (File)
	Jan 18 2025, 2:20 AM

View All Files

Subscribers

None

Tokens

"Like" token, awarded by nfirmani.

Details

Reviewers

amckinley

Commits

rPHU52a394a76bc7: Parse HTTP responses with empty "reason-phrase" properly in…

Summary

Depends on D19628. This ports the fix from that change to PhutilHTTPResponseParser, which is theoretically the future of HTTP response parsing.

Test Plan

Added unit test and made it pass; this code is currently unreachable.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 4 2018, 3:27 PM

Harbormaster completed remote builds in B20728: Diff 46922.Sep 4 2018, 3:27 PM

epriestley requested review of this revision.Sep 4 2018, 3:27 PM

nfirmani awarded a token.Sep 4 2018, 6:51 PM

amckinley accepted this revision.Sep 5 2018, 10:25 PM

This revision is now accepted and ready to land.Sep 5 2018, 10:25 PM

Closed by commit rPHU52a394a76bc7: Parse HTTP responses with empty "reason-phrase" properly in… (authored by epriestley). · Explain WhySep 6 2018, 3:26 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

http/

PhutilHTTPResponseParser.php

2 lines

__tests__/

PhutilHTTPResponseParserTestCase.php

21 lines

Diff 46943

View Options

src/parser/http/PhutilHTTPResponseParser.php

View Options

src/parser/http/tests/PhutilHTTPResponseParserTestCase.php

Parse HTTP responses with empty "reason-phrase" properly in PhutilHTTPResponseParserClosedPublicActions