Page MenuHomePhabricator
Differential D19631

Parse HTTP responses with empty "reason-phrase" properly in PhutilHTTPResponseParser
ClosedPublic
Actions

Authored by epriestley on Sep 4 2018, 3:27 PM.
Tags
None
Referenced Files
F22702667: D19631.id46922.diff
Sat, Oct 3, 2:10 AM
F22563751: D19631.diff
Fri, Sep 25, 12:36 AM
Unknown Object (File)
Aug 19 2026, 10:39 PM
Unknown Object (File)
Aug 14 2026, 1:36 AM
Unknown Object (File)
Aug 13 2026, 8:44 AM
Unknown Object (File)
Aug 12 2026, 10:24 AM
Unknown Object (File)
Jul 6 2026, 1:43 PM
Unknown Object (File)
Apr 17 2026, 7:25 PM
View All Files
Subscribers
None
Tokens
"Like" token, awarded by nfirmani.

Details

Reviewers
amckinley
Commits
rPHU52a394a76bc7: Parse HTTP responses with empty "reason-phrase" properly in…
Summary

Depends on D19628. This ports the fix from that change to PhutilHTTPResponseParser, which is theoretically the future of HTTP response parsing.

Test Plan

Added unit test and made it pass; this code is currently unreachable.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
parser/
http/
2 lines
__tests__/
21 lines

Diff 46943

View Options

src/parser/http/PhutilHTTPResponseParser.php

Loading...
View Options

src/parser/http/__tests__/PhutilHTTPResponseParserTestCase.php

Loading...
Phabricator · Built by Phacility